New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix type declarations for custom message arguments #6354
Conversation
🦋 Changeset detectedLatest commit: c192820 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stof Thanks for your first PR contribution. I couldn't notice the type error due to skipLibCheck: true
.
I appreciate your report right after the 14.12.0 release. 👍🏼
Disabling the checks for lib files will hide typescript errors in the stylelint type definitions, as those are loaded as a lib type when type-checking type-test.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. LGTM 👍🏼
@ybiquitous do you have any estimate about when the fix will be released ? |
@stof Perhaps within a few days. |
thanks |
14.12.1 is released! |
Closes #6353
No, it's self-explanatory.